Fix meson issues by jblueh · Pull Request #2093 · su2code/SU2
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 966
Merged
Conversation
Copy link
Contributor
Proposed Changes
This PR fixes small issues in the meson build system that I noticed during recent work on SU2.
- deprecation warnings about
meson.source_root() - an incorrectly displayed
ninjacommand
PR Checklist
- I am submitting my contribution to the develop branch.
- My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
- My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
- I have added a test case that demonstrates my contribution, if necessary.
- I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.
jblueh added 2 commits
July 27, 2023 16:31
jblueh
added
the
changelog:fix
label
pcarruscag approved these changes Jul 27, 2023
Copy link
Member
pcarruscag
left a comment
pcarruscag
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for fixing these
Copy link
Contributor Author
jblueh
commented
Jul 28, 2023
jblueh commented
Jul 28, 2023Thank you for fixing these
Thanks for the approval @pcarruscag. I can't merge though, the formatting workflow seems to be stuck?
Copy link
Member
pcarruscag
commented
Jul 28, 2023
pcarruscag commented
Jul 28, 2023Interesting
pcarruscag
merged commit
8105a75
into
develop
pcarruscag
deleted the
fix_meson_issues
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment