Fix meson issues by jblueh · Pull Request #2093 · su2code/SU2

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@jblueh

Copy link

Contributor

@jblueh jblueh commented

Jul 27, 2023

edited

Loading

Proposed Changes

This PR fixes small issues in the meson build system that I noticed during recent work on SU2.

  1. deprecation warnings about meson.source_root()
  2. an incorrectly displayed ninja command

PR Checklist

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.
Copy link

Member

@pcarruscag pcarruscag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing these

@jblueh

Copy link

Contributor Author

jblueh commented

Jul 28, 2023

Thank you for fixing these

Thanks for the approval @pcarruscag. I can't merge though, the formatting workflow seems to be stuck?

@pcarruscag

Copy link

Member

Interesting

@pcarruscag pcarruscag merged commit 8105a75 into develop

Jul 28, 2023

@pcarruscag pcarruscag deleted the fix_meson_issues branch

July 28, 2023 15:35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pcarruscag pcarruscag pcarruscag approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jblueh @pcarruscag