Workaround for ASLR/tsan incompatibility by jblueh · Pull Request #2242 · su2code/SU2
Proposed Changes
Explore a workaround along the lines of openvswitch/ovs@fa0dfa1 to fix #2241
Related Work
PR Checklist
- I am submitting my contribution to the develop branch.
- My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
- My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
- I used the pre-commit hook to prevent dirty commits and used
pre-commit run --allto format old commits. - I have added a test case that demonstrates my contribution, if necessary.
- I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.
jblueh
changed the title
[WIP] Workaround for ASLR/tsan incompatibility
Workaround for ASLR/tsan incompatibility
The changes do fix #2241, thread sanitizer builds and tests execute without crashing. The workaround is only needed until a corresponding fix in the github runner is deployed, which will take around a week (actions/runner-images#9491 (comment)). We could merge this now and roll it back later. @pcarruscag
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool thanks for the quick fix 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters