change MPI_QUANTITIES to enum class by bigfooted · Pull Request #2279 · su2code/SU2
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 967
Merged
Conversation
Copy link
Contributor
bigfooted
commented
May 11, 2024
bigfooted
commented
Proposed Changes
Give a brief overview of your contribution here in a few sentences.
change MPI_QUANTITIES to enum class
- I am submitting my contribution to the develop branch.
- My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
- My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
- I used the pre-commit hook to prevent dirty commits and used
pre-commit run --allto format old commits. - I have added a test case that demonstrates my contribution, if necessary.
- I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.
bigfooted added 2 commits
May 11, 2024 22:58
bigfooted
added
the
changelog:chore
label
bigfooted added 2 commits
May 12, 2024 00:03This reverts commit c39b016.
pcarruscag reviewed May 12, 2024
Common/include/option_structure.hpp
Outdated
Show resolved
Hide resolved
Common/include/option_structure.hpp Outdated Show resolved Hide resolved
Common/include/option_structure.hpp
Outdated
Show resolved
Hide resolved
Common/include/option_structure.hpp Outdated Show resolved Hide resolved
bigfooted added 2 commits
May 13, 2024 21:27pcarruscag approved these changes May 14, 2024
bigfooted
merged commit
83cac12
into
develop
bigfooted
deleted the
enumclass_mpi_quantities
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment