Only the V2 header contains a serial number, and there are also cases
where the serial number hasn't been filled in correctly.

Libdivecomputer doesn't use the actual model number for parsing the
Divesoft dives, so hardcoding the Freedom works fine. The main
disadvantage is that all imported dives will show the Divesoft Freedom
as their dive computer model.

Signed-off-by: Jef Driesen <jef@libdivecomputer.org>

requested changes Apr 23, 2025

Now when the descriptor always will use divesoft_freedom_model,
the dc model string will be misleading.

By just including vendor and that it's imported from a file,
it will be correct.

Signed-off-by: Anton Lundin <glance@ac2.se>

glance- added a commit to glance-/subsurface that referenced this pull request

This adds two tests parsing two different DLF files showing that the
code in PR subsurface#4510 works and parses two files which doesn't work in
current master.

Signed-off-by: Anton Lundin <glance@ac2.se>

glance- added a commit to glance-/subsurface that referenced this pull request

This adds two tests parsing two different DLF files showing that the
code in PR subsurface#4510 works and parses two files which doesn't work in
current master.

Signed-off-by: Anton Lundin <glance@ac2.se>

mikeller pushed a commit to mikeller/subsurface that referenced this pull request

This adds two tests parsing two different DLF files showing that the
code in PR subsurface#4510 works and parses two files which doesn't work in
current master.

Signed-off-by: Anton Lundin <glance@ac2.se>
(cherry picked from commit 8dfc776)

mikeller pushed a commit to mikeller/subsurface that referenced this pull request

This adds two tests parsing two different DLF files showing that the
code in PR subsurface#4510 works and parses two files which doesn't work in
current master.

Signed-off-by: Anton Lundin <glance@ac2.se>
(cherry picked from commit 8dfc776)

mikeller pushed a commit to mikeller/subsurface that referenced this pull request

This adds two tests parsing two different DLF files showing that the
code in PR subsurface#4510 works and parses two files which doesn't work in
current master.

Signed-off-by: Anton Lundin <glance@ac2.se>
(cherry picked from commit 8dfc776)

mikeller pushed a commit to mikeller/subsurface that referenced this pull request

This adds two tests parsing two different DLF files showing that the
code in PR subsurface#4510 works and parses two files which doesn't work in
current master.

Signed-off-by: Anton Lundin <glance@ac2.se>
(cherry picked from commit 8dfc776)

mikeller pushed a commit that referenced this pull request

This adds two tests parsing two different DLF files showing that the
code in PR #4510 works and parses two files which doesn't work in
current master.

Signed-off-by: Anton Lundin <glance@ac2.se>
(cherry picked from commit 8dfc776)