Home Original page

Turn "extra info" tab into "dive computer info" tab by bstoeger · Pull Request #4699 · subsurface/subsurface

mikeller

dirkhh

mikeller added a commit to mikeller/subsurface that referenced this pull request

Feb 13, 2026 
Trim extra whitespace from the firmware version reported by
libdivecomputer.

This is to fix display problems in subsurface#4699.

It is an alternative to
subsurface#4708 that minimises the
amount of new C++ constructs that are introduced.

Signed-off-by: Michael Keller <github@ike.ch>

mikeller added a commit to mikeller/subsurface that referenced this pull request

Feb 13, 2026 
Trim extra whitespace from the firmware version reported by
libdivecomputer.

This is to fix display problems in subsurface#4699.

It is an alternative to
subsurface#4708 that minimises the
amount of new C++ constructs that are introduced.

Signed-off-by: Michael Keller <github@ike.ch>

mikeller added a commit to mikeller/subsurface that referenced this pull request

Feb 14, 2026 
Trim extra whitespace from the firmware version reported by
libdivecomputer.

This is to fix display problems in subsurface#4699.

It is an alternative to
subsurface#4708 that minimises the
amount of new C++ constructs that are introduced.

Signed-off-by: Michael Keller <github@ike.ch>
To make clear what this tab is about.

Retain the file names, at least for now.

Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
Some had this property and some didn't. Since they seem not
to be used, remove them.

Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
Show divecomputer-specific data on the divecomputer tab, which
was not shown up to now.

Start with:
model name, serial number, firmware version
date, duration, dive mode

UI was copied from the DiveInformation tab.

Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
These data are stored in dedicated fields in struct divecomputer.
No need to show them twice. They are only removed from the
DiveComputerExtraDataModel and kept in the extra_data array,
so that they are still written out.

Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
Trim values provided by libdivecomputer before displaying them to get
rid of unwanted newlines.

Signed-off-by: Michael Keller <github@ike.ch>