Walkthrough

The change modifies the Docker container stopping logic in DockerRemoveAll to stop all containers regardless of their state, rather than only stopping those in a "running" state. This ensures containers in other states are also properly cleaned up during removal.

Changes

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

• 📝 Generate docstrings

internal/utils/docker.go (1)

106-114: ⚠️ Potential issue | 🟠 Major

Use errdefs.IsNotModified() to ignore benign "already stopped" errors.

Now that every container ID is stopped, Docker returns HTTP 304 Not Modified for containers that are already stopped or in created/exited states, which will abort DockerRemoveAll and skip pruning. Treat those errors as non-fatal so cleanup continues.

🔧 Proposed fix

  result := WaitAll(ids, func(id string) error {
-	if err := Docker.ContainerStop(ctx, id, container.StopOptions{}); err != nil {
-		return errors.Errorf("failed to stop container: %w", err)
-	}
+	if err := Docker.ContainerStop(ctx, id, container.StopOptions{}); err != nil {
+		// Ignore benign errors for already-stopped containers.
+		if errdefs.IsNotModified(err) || errdefs.IsNotFound(err) {
+			return nil
+		}
+		return errors.Errorf("failed to stop container: %w", err)
+	}
 	return nil
  })