Home Original page

Remove reliance on the NIO umbrella module by Joannis · Pull Request #60 · swift-server/RediStack

@Joannis

@Joannis

fabianfett

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Two things left:

  1. We should change Package.swift and depend on the explicit NIOxxx modules. However we should keep depending on NIO for the time being. See AHC.
  2. We should comment in the don't import NIO check in the soundness script.

@Joannis

@Joannis

fabianfett

.product(name: "NIOPosix", package: "swift-nio"),
.product(name: "NIOConcurrencyHelpers", package: "swift-nio"),
.product(name: "Atomics", package: "swift-atomics"),
.product(name: "NIO", package: "swift-nio"),

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we keep the NIO umbrella import for now. Users might depend on it... But we should not use it anywhere.

@Joannis

@Joannis

@Joannis Joannis linked an issue

Jun 18, 2023

that may be closed by this pull request

fabianfett

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!