Cherry pick GitLab 187: Graceful connection close without sending QUIT command by fabianfett · Pull Request #85 · swift-server/RediStack
Conversation
Cherry pick: https://gitlab.com/swift-server-community/RediStack/-/merge_requests/187
Redis connections should not send a QUIT command before closing
Note: Clients should not use this command. Instead, clients should simply close the connection when they're not used anymore. Terminating a connection on the client side is preferable, as it eliminates TIME_WAIT lingering sockets on the server side.
From Redis docs
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I don't think reading the docs that older servers are affected.
fabianfett
deleted the
ff-cherry-pick-graceful-close
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Labels
2 participants