Close connection pool even if some connections are leased/in creation by fabianfett · Pull Request #86 · swift-server/RediStack
Navigation Menu
{{ message }}
swift-server / RediStack Public
- Notifications You must be signed in to change notification settings
- Fork 30
Merged
fabianfett merged 2 commits intoswift-server:mainfrom
Aug 4, 2023Merged
Conversation
Copy link Copy Markdown
Member
fabianfett
commented
Aug 4, 2023
fabianfett
commented
Currently closing a pool, that has leased connections or is currently creating connections, fails. However if you try to close such a pool, it will be caught in an unrecoverable closing state.
Currently closing a pool, that has least connections or currently creates connections fails. However such a close attempt brings the pool in an unrecoverable closing state.
Joannis approved these changes Aug 4, 2023
fabianfett
merged commit
30a43b0
into
swift-server:main
fabianfett
deleted the
ff-close-connectionpool
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment