Home Original page

MNT: use public ast module in setup.py by tacaswell · Pull Request #33 · systemd/pystemd

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@tacaswell

Copy link Copy Markdown

Contributor

The Str object is no longer in in _ast is py38, switch
to using the public ast module instead.

python/cpython#9445
https://bugs.python.org/issue32892

The `Str` object is no longer in in `_ast` is py38, switch
to using the public `ast` module instead.

python/cpython#9445
https://bugs.python.org/issue32892
Copy link Copy Markdown

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aleivag is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@aleivag

Copy link Copy Markdown

Contributor

aleivag commented

Apr 2, 2019

Hey... Thanks for this!!! pluming this PR into our internal testing services...

@facebook-github-bot

Copy link Copy Markdown

@aleivag merged this pull request in 35d1e09.

@tacaswell tacaswell deleted the bld_use_public_ast_module branch

April 3, 2019 16:46

@tacaswell

Copy link Copy Markdown

Contributor Author

Your welcome.

I enjoyed your pycon talk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tacaswell @aleivag @facebook-github-bot