Jac/filter spaces by jacalata · Pull Request #225 · tableau/tabcmd

added 2 commits

February 1, 2023 01:19
Write tests for methods in ds_and_wb class, including a failing test that expects the view_filter to be un-encoded
The logic of the fix is in ds_and_wb:82

Also refactored some methods to get consistent order of args.

anyoung-tableau

@jacalata

- removed super defensive exception catching
- stopped sending filters for workbooks
- CR feedback

jacalata added a commit that referenced this pull request

Jul 28, 2023
Fixes, code enhancements
* remove lowercase call while parsing csv for adding users
* set user agent (#219)
* Add and clean up logging, always include version in logs (#234, #224)
* Encoding filter values to handle spaces and special chars in filters  (#225)
* replace polling code with library call
* readme updates (#235)
* Read and warn when user sets thumbnail options. (including 'not yet implemented' message for --thumbnail-group)
* freeze tsc dependency (#248)

New functionality
* added new --filter option to pass in un-encoded value for simpler input
* Add --url, --include-all/--embedded-datasources for create/refresh/delete extract commands (#227)
* Add new command for listing content on the site (#230)
* Implement publishing options overwrite/append/replace arguments (including not-yet-implemented message for --replace) (#236)
* implement --proxy, --no-proxy,  --use-certificate option  (#241)
* add --token-file option (#243)

---------

Co-authored-by: Bhuvnesh Singh <bhuvnesh.singh@salesforce.com>