Add right and bottom of area to JSON output by laigor · Pull Request #265

Add right and bottom of area to JSON output by laigor · Pull Request #265 · tabulapdf/tabula-java

Merged

jazzido merged 1 commit intotabulapdf:masterfrom

laigor:master

Dec 11, 2018

Merged

Add right and bottom of area to JSON output#265
jazzido merged 1 commit intotabulapdf:masterfrom
laigor:master

Conversation

Copy link

Contributor

laigor commented
Dec 7, 2018

No description provided.

Add right and bottom of area to JSON output

545db99

laigor mentioned this pull request

Dec 7, 2018

tabula-java and tabula auto-detect tables give different results #260

Closed

Copy link

Contributor

jazzido commented
Dec 7, 2018

Hi @laigor,

Thanks for your contribution! I noticed that the tests for the JSON writer are failing after your commit. Would you mind updating this PR with the fixes?

Thanks!

Copy link

Contributor Author

laigor commented
Dec 9, 2018

I saw that the tests do not pass, but I do not know how to fix them.

Copy link

Member

jeremybmerrill commented
Dec 9, 2018

I haven't checked, but if I recall correctly, the test is just checking that the output hasn't changed. Since this adds the right and bottom... the output has changed. It's presumably just a matter of changing the file the tests check against to the current output...

jazzido merged commit 545db99 into tabulapdf:master