fix(compose): avoid race conditions when caching services by mdelapenya · Pull Request #2528 · testcontainers/testcontainers-go

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Comments

Conversation

@mdelapenya

Copy link

Member

What does this PR do?

This PR uses the existing lock to protect the access to the containers map, which after #2485 caused the race condition.

Why is it important?

Prevent race conditions

Related issues

How to test this PR

I discovered this issue while running the compose tests with -race.

@mdelapenya mdelapenya requested a review from a team as a code owner

May 3, 2024 08:41

@mdelapenya mdelapenya added the bug

An issue with the library

label

May 3, 2024

@mdelapenya mdelapenya self-assigned this

May 3, 2024

@netlify

Copy link

netlify bot commented

May 3, 2024

edited

Loading

Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit d702774
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/6634a34deb67fd000827ddc0
😎 Deploy Preview https://deploy-preview-2528--testcontainers-go.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.


To edit notification comments on pull requests, go to your Netlify site configuration.

@mdelapenya mdelapenya merged commit 5e97046 into testcontainers:main

May 3, 2024

@mdelapenya mdelapenya added the compose

Docker Compose.

label

May 3, 2024

@mdelapenya mdelapenya deleted the fix-reace-condition-compose branch

May 3, 2024 22:56

mdelapenya added a commit to khartld/testcontainers-go that referenced this pull request

May 7, 2024
* main: (44 commits)
  feat: expose JSON representation of a container with Inspect (testcontainers#2534)
  chore(deps): bump test-summary action to v2.3 (testcontainers#2535)
  chore(deps): bump jinja2 from 3.1.3 to 3.1.4 (testcontainers#2533)
  Update devcontainer image (testcontainers#2531)
  chore(influxdb): include more characters in wait for log regex (testcontainers#2532)
  fix(compose): avoid race conditions when caching services (testcontainers#2528)
  chore(deps): bump golangci/golangci-lint-action from 3.7.0 to 5.1.0 (testcontainers#2525)
  chore(deps): bump mkdocs-material from 8.2.7 to 9.1.21 (testcontainers#2524)
  chore(compose): return error in options (testcontainers#2520)
  chore(deps): bump github.com/compose-spec/compose-go/v2 from v2.0.0-rc8 to v2.1.0 (testcontainers#2519)
  chore(deps): bump github.com/containerd/containerd from 1.7.12 to 1.7.15 (testcontainers#2517)
  break: return error from Customize request option (testcontainers#2267)
  fix: wrong copy paste (testcontainers#2515)
  docs: add documentation for Exec method (testcontainers#2451)
  docs: document the SSHd tunnel (testcontainers#2514)
  fix: enhance host configuration port binding (testcontainers#2512)
  feat: forward host ports to a container using an SSH tunnel (testcontainers#2471)
  Update follow_logs.md with adding missing package (testcontainers#2513)
  fix: don't retry on permanent APIClient errors (testcontainers#2506)
  feat: support overriding the default recreate options for compose (testcontainers#2511)
  ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@mdelapenya mdelapenya

Labels

bug

An issue with the library

compose

Docker Compose.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mdelapenya