fix: update search bar eval in mkdocs by mdelapenya · Pull Request #2547 · testcontainers/testcontainers-go

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Comments

Conversation

@mdelapenya

Copy link

Member

@mdelapenya mdelapenya commented

May 20, 2024

edited

Loading

What does this PR do?

This PR updates the name of the mkdocs' search plugin, from search to material/search, in the header.html partial.

Render URL: https://deploy-preview-2547--testcontainers-go.netlify.app/

Why is it important?

Search bar was not shown.

Related issues

@mdelapenya mdelapenya requested a review from a team as a code owner

May 20, 2024 14:32

@mdelapenya mdelapenya added the documentation

Docs, docs, docs.

label

May 20, 2024

@mdelapenya mdelapenya self-assigned this

May 20, 2024

@netlify

Copy link

netlify bot commented

May 20, 2024

edited

Loading

Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit 2eb9f5f
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/664b5ef42783dd00083d5b42
😎 Deploy Preview https://deploy-preview-2547--testcontainers-go.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.


To edit notification comments on pull requests, go to your Netlify site configuration.

@mdelapenya

Copy link

Member Author

@leocross at the moment any tc-lang docs site needs to update, we must update our customisation with this and #2524

@mdelapenya mdelapenya merged commit a351a4c into testcontainers:main

May 20, 2024

@mdelapenya mdelapenya deleted the fix-search-docs branch

May 20, 2024 15:38

mdelapenya added a commit to bearrito/testcontainers-go that referenced this pull request

Jun 11, 2024
* main: (48 commits)
  Fix race condition when looking up reaper (ryuk) container (testcontainers#2508)
  chore: bring golangci-lint back (testcontainers#2571)
  docs(compose): Fix typo docker compose docs (testcontainers#2565)
  Handle error properly during port forwarding initialization. (testcontainers#2550)
  chore: pin vearch version (testcontainers#2568)
  feat: add vearch module (testcontainers#2560)
  chore: run tests against latest Docker engine, nightly (testcontainers#2566)
  chore(deps): bump mkdocs-include-markdown-plugin from 6.0.4 to 6.0.7 (testcontainers#2562)
  Fix network accessor for port-forwarding feature (testcontainers#2551)
  --- (testcontainers#2549)
  fix: update search bar eval in mkdocs (testcontainers#2547)
  docs: improve contributing docs for code snippets (testcontainers#2546)
  chore: use a virtualenv for working with the docs site (testcontainers#2545)
  docs: document test session semantics (testcontainers#2544)
  feat(ryuk): allow to configure ryuk timeouts using env variables (testcontainers#2541)
  docs: fix CircleCI docs (testcontainers#2539)
  fix: add import to module generation (testcontainers#2537)
  chore: prepare for next minor development cycle (0.32.0)
  chore: use new version (v0.31.0) in modules and examples
  feat(mongodb): add replica set support via opts (testcontainers#2469)
  ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@mdelapenya mdelapenya

Labels

documentation

Docs, docs, docs.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mdelapenya