fix: docker config error handling when config file does not exist by stevenh · Pull Request #2772 · testcontainers/testcontainers-go
stevenh
changed the title
fix: auth with no docker config
fix: docker config error handling
Handle file not exist error in getDockerAuthConfigs, treating it as if no authentication was provided. Use config directly for cache instead of loading the file a second time which may be the wrong file if loaded from the environment. Correctly handle json decode errors in getDockerConfig instead of falling back to the default config, which would result in unexpected behaviour. Tests refactored to ensure all edge cases for getDockerConfig and getDockerAuthConfigs are handled. Fixes #2767
stevenh
marked this pull request as ready for review
This was referenced
Sep 7, 2024
mdelapenya
changed the title
fix: docker config error handling
fix: docker config error handling when config file does not exist
mdelapenya added a commit that referenced this pull request
Sep 10, 2024mdelapenya added a commit to mdelapenya/testcontainers-go that referenced this pull request
Sep 11, 2024mdelapenya added a commit to mdelapenya/testcontainers-go that referenced this pull request
Sep 18, 2024mdelapenya added a commit to mdelapenya/testcontainers-go that referenced this pull request
Sep 23, 2024mdelapenya added a commit that referenced this pull request
Sep 26, 2024* main: (29 commits) fix: template for code generation (#2800) fix: update module path (#2797) fix: container logging deadlocks (#2791) chore: use a much smaller image for testing (#2795) fix: parallel containers clean race (#2790) fix(registry): wait for (#2793) fix: container timeout test (#2792) docs: document redpanda options (#2789) feat: support databend module (#2779) chore: golangci-lint 1.61.0 (#2787) fix(mssql): bump Docker image version (#2786) fix: handle 127 error code for podman compatibility (#2778) fix: do not override ImageBuildOptions.Labels when building from a Dockerfile (#2775) feat(mongodb): Wait for mongodb module with a replicaset to finish (#2777) fix(postgres): Apply default snapshot name if no name specified (#2783) fix: resource clean up for tests and examples (#2738) ci: add generate for mocks (#2774) fix: docker config error handling when config file does not exist (#2772) docs: refine heading badges in README (#2770) feat(wait): for file (#2731) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters