golangci-lint: enable thelper linter by mmorel-35 · Pull Request #2834 · testcontainers/testcontainers-go
Navigation Menu
{{ message }}
testcontainers / testcontainers-go Public
- Notifications You must be signed in to change notification settings
- Fork 591
Comments
Merged
mdelapenya merged 1 commit intotestcontainers:mainfrom
Oct 18, 2024Merged
golangci-lint: enable thelper linter#2834
mdelapenya merged 1 commit intotestcontainers:mainfrom
golangci-lint: enable thelper linter#2834
mdelapenya merged 1 commit intotestcontainers:mainfrom
Conversation
Copy link
Contributor
mmorel-35
commented
Oct 18, 2024
mmorel-35
commented
What does this PR do?
Setup thelper linter and apply it’s recommandations .
Why is it important?
Thelper detects tests helpers which is not start with t.Helper() method.
Signed-off-by: Matthieu MOREL matthieu.morel35@gmail.com
Copy link
✅ Deploy Preview for testcontainers-go ready!
| Name | Link |
|---|---|
| 🔨 Latest commit | 9e282e5 |
| 🔍 Latest deploy log | https://app.netlify.com/sites/testcontainers-go/deploys/67125186bc56d70008127b99 |
| 😎 Deploy Preview | https://deploy-preview-2834--testcontainers-go.netlify.app |
| 📱 Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
mmorel-35
force-pushed
the
golangci-lint/thelper
branch
2 times, most recently
from
8b80f4d to
d9dcd0b
Compare
mdelapenya previously approved these changes Oct 18, 2024
Copy link
Member
mdelapenya
left a comment
mdelapenya
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for this improvement 🙇
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
mmorel-35
dismissed
mdelapenya’s stale review
via
9e282e5
mmorel-35
force-pushed
the
golangci-lint/thelper
branch
from
d9dcd0b to
9e282e5
Compare
mmorel-35
marked this pull request as ready for review
mmorel-35
requested a review
from a team
as a code owner
mdelapenya approved these changes Oct 18, 2024
mdelapenya
self-assigned this
mdelapenya
merged commit
b74984d
into
testcontainers:main
mmorel-35
deleted the
golangci-lint/thelper
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment