fix: log test data race by stevenh · Pull Request #2863 · testcontainers/testcontainers-go
Navigation Menu
{{ message }}
testcontainers / testcontainers-go Public
- Notifications You must be signed in to change notification settings
- Fork 591
Comments
Merged
Conversation
Fix a data race when accessing logger in consumer test.
stevenh
requested a review
from a team
as a code owner
Copy link
✅ Deploy Preview for testcontainers-go ready!
| Name | Link |
|---|---|
| 🔨 Latest commit | 96f5e53 |
| 🔍 Latest deploy log | https://app.netlify.com/sites/testcontainers-go/deploys/67225a0b53665e000866f60d |
| 😎 Deploy Preview | https://deploy-preview-2863--testcontainers-go.netlify.app |
| 📱 Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
stevenh
requested a review
from mdelapenya
mdelapenya approved these changes Oct 30, 2024
Copy link
Member
mdelapenya
left a comment
mdelapenya
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
mdelapenya
merged commit
a489482
into
main
mdelapenya
self-assigned this
mdelapenya
deleted the
fix/log-data-race
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment