refactor(cockroachdb): to use request driven options by stevenh · Pull Request #2883 · testcontainers/testcontainers-go
stevenh
marked this pull request as ready for review
stevenh
marked this pull request as ready for review
Co-authored-by: Manuel de la Peña <social.mdelapenya@gmail.com>
Simplify the connection handling in cockroachdb so that ConnectionString can be used without the user doing extra work to handle TLS if enabled. Deprecate TLSConfig which is no longer needed separately. BREAKING_CHANGE: This now returns a registered connection string so is no longer compatible with pgx.ParseConfig, use ConnectionConfig for this use case instead.
Extract TLS certificate wait strategy into a dedicated wait type so it can be reused. Implement walk method which can be used to identify wait strategies in a request chain. Use embed to simplify wait test loading of certs.
mdelapenya added a commit to mdelapenya/testcontainers-go that referenced this pull request
Dec 5, 2024mdelapenya added a commit to mtellis2/testcontainers-go that referenced this pull request
Dec 11, 2024mdelapenya added a commit to mdelapenya/testcontainers-go that referenced this pull request
Dec 13, 2024mdelapenya added a commit to mdelapenya/testcontainers-go that referenced this pull request
Jan 8, 2025This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters