refactor(cockroachdb): to use request driven options by stevenh · Pull Request #2883 · testcontainers/testcontainers-go

mdelapenya

@stevenh stevenh marked this pull request as ready for review

November 22, 2024 15:54

mdelapenya

@stevenh stevenh marked this pull request as ready for review

November 27, 2024 17:07

@martskins @stevenh

@martskins @stevenh

@martskins @stevenh

Co-authored-by: Steven Hartland <stevenmhartland@gmail.com>
Co-authored-by: Steven Hartland <stevenmhartland@gmail.com>

@martskins @stevenh

@martskins @stevenh

Co-authored-by: Manuel de la Peña <social.mdelapenya@gmail.com>

@martskins @stevenh

@martskins @stevenh

Simplify the connection handling in cockroachdb so that ConnectionString
can be used without the user doing extra work to handle TLS if enabled.

Deprecate TLSConfig which is no longer needed separately.

BREAKING_CHANGE: This now returns a registered connection string so is
no longer compatible with pgx.ParseConfig, use ConnectionConfig for this
use case instead.
Refactor cockroachdb module to to use request driven options,
simplifying the flow.
Various fixes and remove the ability to configure certs using the
default generated ones instead.
Add the missing data file and remove unused constants.

@stevenh

@stevenh

Extract TLS certificate wait strategy into a dedicated wait type so it
can be reused.

Implement walk method which can be used to identify wait strategies in
a request chain.

Use embed to simplify wait test loading of certs.
Remove the now unused customizer.

@stevenh

Fix lint style issue for blank line.

@stevenh

Clarified the impact of run defaults.

mdelapenya

@mdelapenya mdelapenya added the chore

Changes that do not impact the existing functionality

label

Dec 2, 2024

mdelapenya added a commit to mdelapenya/testcontainers-go that referenced this pull request

Dec 5, 2024

mdelapenya added a commit to mtellis2/testcontainers-go that referenced this pull request

Dec 11, 2024

mdelapenya added a commit to mdelapenya/testcontainers-go that referenced this pull request

Dec 13, 2024

mdelapenya added a commit to mdelapenya/testcontainers-go that referenced this pull request

Jan 8, 2025