chore!: rename EnpointSettingsModifier to EndpointSettingsModifier by NathanBaulch · Pull Request #2941 · testcontainers/testcontainers-go
Navigation Menu
{{ message }}
testcontainers / testcontainers-go Public
- Notifications You must be signed in to change notification settings
- Fork 591
Comments
Merged
mdelapenya merged 1 commit intotestcontainers:mainfrom
Jan 14, 2025Merged
Conversation
Copy link
Contributor
NathanBaulch
commented
Jan 14, 2025
NathanBaulch
commented
Rename EnpointSettingsModifier to EndpointSettingsModifier, as discussed in #2940.
NathanBaulch
requested a review
from a team
as a code owner
Copy link
✅ Deploy Preview for testcontainers-go ready!
| Name | Link |
|---|---|
| 🔨 Latest commit | 483dbf2 |
| 🔍 Latest deploy log | https://app.netlify.com/sites/testcontainers-go/deploys/6785ae7cb04c360008d6c3d6 |
| 😎 Deploy Preview | https://deploy-preview-2941--testcontainers-go.netlify.app |
| 📱 Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
mdelapenya
self-assigned this
mdelapenya approved these changes Jan 14, 2025
Copy link
Member
mdelapenya
left a comment
mdelapenya
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
mdelapenya
changed the title
fix!: typo in EnpointSettingsModifier
chore!: rename EnpointSettingsModifier to EndpointSettingsModifier
Copy link
Member
mdelapenya
commented
Jan 14, 2025
mdelapenya commented
Jan 14, 2025@NathanBaulch I've renamed the PR so that it's even clearer when reading the release notes.
NathanBaulch
deleted the
enpointsettingsmodifier
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment