fix: use PortEndpoint() in a few more modules by ash2k · Pull Request #3207 · testcontainers/testcontainers-go
What does this PR do?
More cleanup.
Why is it important?
Related issues
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, just one question.
| return "", err | ||
| } | ||
| return fmt.Sprintf("neo4j://%s:%d", host, mappedPort.Int()), nil | ||
| return c.PortEndpoint(ctx, "7687/tcp", "neo4j") |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: should this use the defaultBoltPort constant?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the constants. 👍
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
ash2k
deleted the
use-mapped-port3
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters