Migrate kafkajs to @confluentinc/kafka-javascript by joebowbeer · Pull Request #1192 · testcontainers/testcontainers-node
Conversation
Closes #1191
Migration Guide: https://docs.confluent.io/kafka-clients/javascript/current/migration.html
I used the following commands to update the packages and lock:
nvm use 24 npm install -g npm@latest npm install npm audit fix cd packages/modules/kafka npm install -D @confluentinc/kafka-javascript npm uninstall kafkajs cd ../redpanda npm install -D @confluentinc/kafka-javascript npm uninstall kafkajs
Notes:
- I needed to install
npm >= 11.6.3to avoid adding extraneous 'peer: true' diffs to the package-lock - I ran
npm audit fixto address the high severity finding below
# npm audit report
jws =4.0.0 || <3.2.3
Severity: high
auth0/node-jws Improperly Verifies HMAC Signature
https://github.com/advisories/GHSA-869p-cjfg-cm3x
fix available via `npm audit fix`
node_modules/jsonwebtoken/node_modules/jws
node_modules/jws
@cristianrgreco I addressed the three SASL_SSL test errors
This is ready to merge.
Btw, one of the unmodified tests fails for me locally in Rancher Desktop on Apple Silicon, as noted
This is because there's no arm64 image for the requested zookeeper image.
Thanks @joebowbeer! I'm a bit swamped at the moment, will look at it soon
cristianrgreco
changed the title
chore: migrate kafkajs to @confluentinc/kafka-javascript
Migrate kafkajs to @confluentinc/kafka-javascript
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters