Move Vault test client from node-vault to @litehex/node-vault by cristianrgreco · Pull Request #1263 · testcontainers/testcontainers-node

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@cristianrgreco

Copy link Copy Markdown

Collaborator

@cristianrgreco cristianrgreco commented

Mar 10, 2026

edited

Loading

Summary

  • move the Vault module test client from node-vault to @litehex/node-vault
  • migrate Vault integration test usage to Client + kv2.write/read
  • update package-lock.json to remove the postman-request/legacy node-vault chain

Why

  • upstream issue: node-vault#272
  • the critical vulnerabilities in that chain have been open for months, even with a PR fix in place upstream

Verification Commands

  • npm run format
  • npm run lint
  • npm run test -- packages/modules/vault/src/vault-container.test.ts
  • npm audit

Test Results

  • packages/modules/vault/src/vault-container.test.ts: 2 passed, 0 failed

Semver Impact

  • patch
  • non-breaking evidence: no public runtime API or exported types changed; only Vault module test dependency and tests were updated

@netlify

Copy link Copy Markdown

netlify bot commented

Mar 10, 2026

edited

Loading

Deploy Preview for testcontainers-node ready!

Name Link
🔨 Latest commit 27b22da
🔍 Latest deploy log https://app.netlify.com/projects/testcontainers-node/deploys/69afe9940cc5530008d77975
😎 Deploy Preview https://deploy-preview-1263--testcontainers-node.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.


To edit notification comments on pull requests, go to your Netlify project configuration.

@cristianrgreco cristianrgreco added maintenance

Improvements that do not change functionality

patch

Backward compatible bug fix

labels

Mar 10, 2026

@cristianrgreco cristianrgreco changed the title Use @litehex/node-vault in Vault module tests Move Vault test client from node-vault to @litehex/node-vault

Mar 10, 2026

@cristianrgreco cristianrgreco force-pushed the codex/vault-client-spike branch from 18d1492 to 27b22da Compare

March 10, 2026 09:51

@cristianrgreco cristianrgreco merged commit 47dad03 into main

Mar 10, 2026

691 checks passed

@cristianrgreco cristianrgreco deleted the codex/vault-client-spike branch

March 10, 2026 15:45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

maintenance

Improvements that do not change functionality

patch

Backward compatible bug fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@cristianrgreco