Add missing trailing newline before adding new entry with `set_key` by bbc2 · Pull Request #361

Add missing trailing newline before adding new entry with `set_key` by bbc2 · Pull Request #361 · theskumar/python-dotenv

Sometimes, the source file doesn't have a trailing newline. If we add a new binding in such a case, we need to add a newline before the new binding.

Closes #360.

Sometimes, the source file doesn't have a trailing newline.  If we add a
new binding in such a case, we need to add a newline before the new
binding.

bbc2 mentioned this pull request

Oct 23, 2021

I don't know the reason but I have to mention that we maintain this package in our spare time, so we're not always available to do code reviews.

In my case, I like to leave my MRs open for a while so that other developers get a chance to comment on them. I think this one has waited long enough so I'm going to merge it.

bbc2 deleted the add-missing-newline branch

November 11, 2021 12:23