Gracefully handle code which has been imported from a zipfile by samwyma · Pull Request #456 · theskumar/python-dotenv
Navigation Menu
{{ message }}
theskumar / python-dotenv Public
- Notifications You must be signed in to change notification settings
- Fork 517
Merged
Gracefully handle code which has been imported from a zipfile#456
theskumar merged 1 commit intotheskumar:mainfrom
Gracefully handle code which has been imported from a zipfile#456
theskumar merged 1 commit intotheskumar:mainfrom
Conversation
Copy link Copy Markdown
Contributor
samwyma
commented
Apr 10, 2023
samwyma
commented
I encountered this issue when loading my codebase into Spark via the --py-file option. Basically, if a file in a zip archive tries to call load_dotenv(), and that file is then imported, it will cause an error. Hopefully the test cases are self-explanatory!
Copy link Copy Markdown
Owner
theskumar
commented
Apr 17, 2023
theskumar commented
Apr 17, 2023Thanks you @samwyma for this patch and a comprehensive test case.
theskumar
merged commit
137bc3d
into
theskumar:main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment