test(git-browse): add unit tests by vanpipy · Pull Request #1127 · tj/git-extras
Navigation Menu
{{ message }}
tj / git-extras Public
- Notifications You must be signed in to change notification settings
- Fork 1.2k
Merged
spacewander merged 3 commits intotj:mainfrom
Jan 5, 2024Merged
test(git-browse): add unit tests#1127
spacewander merged 3 commits intotj:mainfrom
test(git-browse): add unit tests#1127
spacewander merged 3 commits intotj:mainfrom
Conversation
vanpipy added 2 commits
January 2, 2024 23:50
vanpipy
requested review from
hyperupcall and
spacewander
Copy link Copy Markdown
Collaborator
hyperupcall
commented
Jan 3, 2024
hyperupcall commented
Jan 3, 2024LGTM
hyperupcall approved these changes Jan 3, 2024
spacewander reviewed Jan 4, 2024
tests/test_git_browse.py
Outdated
tests/test_git_browse.py Outdated
| import os, subprocess | ||
| from testpath import MockCommand, modified_env | ||
|
|
||
| github_origin = "https://github.com/vanpipy/git-extras" |
Copy link Copy Markdown
Collaborator
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to use tj/git-extras in the github test case?
Copy link Copy Markdown
Collaborator Author
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update
Copy link Copy Markdown
Collaborator Author
vanpipy
commented
Jan 4, 2024
vanpipy commented
Jan 4, 2024Please squash and merge this PR cause the I did not squash the commits manually to avoid the force pushing.
spacewander approved these changes Jan 5, 2024
spacewander
merged commit
b54d8c7
into
tj:main
Copy link Copy Markdown
Collaborator
spacewander
commented
Jan 5, 2024
spacewander commented
Jan 5, 2024@vanpipy
Thanks!
vanpipy
deleted the
feature/test-git-browse
branch
chenrui333
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants