fix(git-bulk): quiet find errors by default by pierreay · Pull Request #1196 · tj/git-extras
Navigation Menu
{{ message }}
tj / git-extras Public
- Notifications You must be signed in to change notification settings
- Fork 1.2k
Merged
spacewander merged 1 commit intotj:mainfrom
Feb 20, 2025Merged
fix(git-bulk): quiet find errors by default#1196
spacewander merged 1 commit intotj:mainfrom
fix(git-bulk): quiet find errors by default#1196
spacewander merged 1 commit intotj:mainfrom
Conversation
Copy link Copy Markdown
Contributor
pierreay
commented
Feb 15, 2025
pierreay
commented
It may be a bad experience for a user to see a bunch of find errors (e.g., file name too long, no permissions, etc.) when using git-bulk. I feel like it is not the job of the tool to report all errors that find can throws when searching all files under a hierarchy. Therefore, I quiet the find errors by default in this PR. If showing its errors is really on purpose, maybe we could create a flag to do so?
pierreay
marked this pull request as ready for review
hyperupcall approved these changes Feb 20, 2025
Copy link Copy Markdown
Collaborator
hyperupcall
left a comment
hyperupcall
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, sounds reasonable to me!
spacewander approved these changes Feb 20, 2025
Copy link Copy Markdown
Collaborator
spacewander
commented
Feb 20, 2025
spacewander commented
Feb 20, 2025@pierreay
Merged. Thanks!
pierreay
deleted the
feat/git-bulk-quiet-find-errors
branch
BrewTestBot
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants