Removed xargs from git-effort by tfendin · Pull Request #956 · tj/git-extras
Navigation Menu
{{ message }}
tj / git-extras Public
- Notifications You must be signed in to change notification settings
- Fork 1.2k
Merged
spacewander merged 1 commit intotj:masterfrom
Mar 1, 2022Merged
Removed xargs from git-effort#956
spacewander merged 1 commit intotj:masterfrom
Removed xargs from git-effort#956
spacewander merged 1 commit intotj:masterfrom
Conversation
Copy link Copy Markdown
Contributor
This is one way to solve issue #953, but it's a little bit flawed.
The problem is that we used xargs --max-args 1 --replace % -c bash "effort \"%\"", because the function effort only takes one argument and we want it to be quoted. --max-args and --replace are conflicting in newer versions of xargs.
In this PR I've removed xargs and only use bash code to call effort. However, the previous implementation used the --max-procs=4 option to xargs to use effort in four "threads". This version forks heavily, which could cause performance problems in the rest of the system.
I have only done some minor tests in one repo, it should be tested in more repos and on other OS:es as well.
spacewander approved these changes Feb 27, 2022
spacewander
merged commit
42458d8
into
tj:master
tfendin
mentioned this pull request
tfendin
deleted the
xargs-conflicting-args
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment