Removed xargs from git-effort by tfendin · Pull Request #956 · tj/git-extras

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@tfendin

Copy link Copy Markdown

Contributor

@tfendin tfendin commented

Feb 25, 2022

edited

Loading

This is one way to solve issue #953, but it's a little bit flawed.
The problem is that we used xargs --max-args 1 --replace % -c bash "effort \"%\"", because the function effort only takes one argument and we want it to be quoted. --max-args and --replace are conflicting in newer versions of xargs.
In this PR I've removed xargs and only use bash code to call effort. However, the previous implementation used the --max-procs=4 option to xargs to use effort in four "threads". This version forks heavily, which could cause performance problems in the rest of the system.
I have only done some minor tests in one repo, it should be tested in more repos and on other OS:es as well.

spacewander reacted with thumbs up emoji

@spacewander spacewander merged commit 42458d8 into tj:master

Mar 1, 2022

@tfendin tfendin deleted the xargs-conflicting-args branch

March 6, 2022 19:39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spacewander spacewander spacewander approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tfendin @spacewander