feat(freezeV2): optimize Stake 2.0 APIs by lxcmyf · Pull Request #5260 · tronprotocol/java-tron

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@lxcmyf

Copy link

Contributor

@lxcmyf lxcmyf commented

Jun 5, 2023

edited

Loading

What does this PR do?
Optimize cancelallunfreezev2 and delegateresource code logic
Why are these changes required?

This PR has been tested by:

  • Unit Tests
  • Manual Testing

Follow up

Extra details

@lxcmyf lxcmyf force-pushed the release_v4.7.2 branch 16 times, most recently from 6619d31 to 4bd45d4 Compare

June 6, 2023 10:11
break;
}
case ALLOW_OPTIMIZE_LOCK_DELEGATE_RESOURCE: {
case MAX_NUMBER_OF_LOCK_PERIOD: {
Copy link

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MAX_LOCK_PERIOD_FOR_DELEGATION maybe better?

@lxcmyf lxcmyf force-pushed the release_v4.7.2 branch 8 times, most recently from 65bb5ef to 5be8621 Compare

June 7, 2023 05:32
@Setter
public long allowOptimizeLockDelegateResource;
public long maxDelegateLockPeriod;

Copy link

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the use of allowCancelAllUnfreezeV2 and maxDelegateLockPeriod.

@lxcmyf lxcmyf changed the title feat(freezeV2): optimize some code logic feat(freezeV2): optimize Stake 2.0 APIs

Jun 7, 2023
Signed-off-by: liuxincheng <lxcmyf@qq.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@jwrct jwrct jwrct left review comments

@tomatoishealthy tomatoishealthy tomatoishealthy approved these changes

@halibobo1205 halibobo1205 halibobo1205 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lxcmyf @tomatoishealthy @jwrct @halibobo1205