Home Original page

feat(net): delete four unused paramaters in Args by 317787106 · Pull Request #5441 · tronprotocol/java-tron

@317787106

What does this PR do?

  • delete four unused config items in CommonParameter. include:
  1. node.discovery.public.home.node
  2. node.discovery.ping.timeout
  3. node.p2p.pingInterval
  4. p2pNodeId

Why are these changes required?

This PR has been tested by:

  • Unit Tests
  • Manual Testing

Follow up

Extra details

@317787106

jwrct

//public static final String NODE_DISCOVERY_PUBLIC_HOME_NODE = "node.discovery.public.home.node";
//public static final String NODE_DISCOVERY_PING_TIMEOUT = "node.discovery.ping.timeout";

public static final String NODE_P2P_PING_INTERVAL = "node.p2p.pingInterval";

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not delete NODE_P2P_PING_INTERVAL?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, there is something wrong when split pr. I have deleted it.

public int minParticipationRate;
@Getter
public P2pConfig p2pConfig;
@Getter

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This modification has nothing to do with this PR, right?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, there is something wrong when split pr. I have deleted it.

// public long nodeDiscoveryPingTimeout;
// @Getter
// @Setter
// public long nodeP2pPingInterval;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is it commented out instead of just deleting the code?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could delete it next release version.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just delete it?

+ 1, git ensures that changes are kept.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok，I will delete it

jiangyuanshu added 3 commits

August 23, 2023 18:11

xxo1shine

jiangyuanshu added 3 commits

August 28, 2023 14:43

jwrct