feat(net): fix bug of getting head block concurrently by 317787106 · Pull Request #5532 · tronprotocol/java-tron
Navigation Menu
{{ message }}
tronprotocol / java-tron Public
- Notifications You must be signed in to change notification settings
- Fork 1.6k
Merged
317787106 merged 4 commits intotronprotocol:release_v4.7.3from
Oct 12, 2023Merged
feat(net): fix bug of getting head block concurrently#5532
317787106 merged 4 commits intotronprotocol:release_v4.7.3from
feat(net): fix bug of getting head block concurrently#5532
317787106 merged 4 commits intotronprotocol:release_v4.7.3from
Conversation
Copy link
317787106
commented
Oct 12, 2023
317787106
commented
What does this PR do?
- fix bug of getting head block concurrently in construct ChainInventoryMessage
Why are these changes required?
This PR has been tested by:
- Unit Tests
- Manual Testing
Follow up
Extra details
jiangyuanshu added 2 commits
October 12, 2023 12:16
Copy link
Codecov Report
Merging #5532 (e352152) into release_v4.7.3 (9842b3f) will increase coverage by
1.02%.
Report is 19 commits behind head on release_v4.7.3.
The diff coverage is74.50%.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
@@ Coverage Diff @@ ## release_v4.7.3 #5532 +/- ## ==================================================== + Coverage 64.99% 66.02% +1.02% - Complexity 10020 10152 +132 ==================================================== Files 894 894 Lines 53816 53847 +31 Branches 5926 5929 +3 ==================================================== + Hits 34979 35552 +573 + Misses 16123 15516 -607 - Partials 2714 2779 +65
| Files | Coverage Δ | |
|---|---|---|
| framework/src/main/java/org/tron/core/Wallet.java | 58.45% <ø> (+9.72%) |
⬆️ |
| ...ices/http/solidity/SolidityNodeHttpApiService.java | 94.11% <100.00%> (+91.08%) |
⬆️ |
| ...a/org/tron/tool/litefullnode/LiteFullNodeTool.java | 75.55% <100.00%> (+0.07%) |
⬆️ |
| ...e/net/messagehandler/SyncBlockChainMsgHandler.java | 30.15% <0.00%> (-1.59%) |
⬇️ |
| .../main/java/org/tron/core/db2/common/TxCacheDB.java | 84.81% <81.39%> (-0.84%) |
⬇️ |
... and 48 files with indirect coverage changes
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more
jiangyuanshu added 2 commits
October 12, 2023 15:11jwrct approved these changes Oct 12, 2023
xxo1shine approved these changes Oct 12, 2023
halibobo1205
added this to the
GreatVoyage-v4.7.3 milestone
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment