dependency(jetty): upgrade for security by halibobo1205 · Pull Request #5571 · tronprotocol/java-tron

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@halibobo1205

Copy link

Contributor

@halibobo1205 halibobo1205 commented

Nov 3, 2023

edited

Loading

@halibobo1205 halibobo1205 changed the title dependency(jetty): upgrade for security. dependency(jetty): upgrade for security

Nov 3, 2023

@halibobo1205 halibobo1205 added this to the GreatVoyage-v4.7.4 milestone

Nov 8, 2023

@halibobo1205 halibobo1205 self-assigned this

Nov 8, 2023

@lvs007 lvs007 requested review from 317787106 and jwrct

November 10, 2023 04:00
compile 'org.eclipse.jetty:jetty-servlet:9.4.49.v20220914'
compile 'org.eclipse.jetty:jetty-server:9.4.53.v20231009'
compile 'org.eclipse.jetty:jetty-servlet:9.4.53.v20231009'
compile 'com.alibaba:fastjson:1.2.83'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not solve other dependency security also but only jetty? such as bcprov-jdk15on in https://github.com/tronprotocol/libp2p/pull/74/files.

Copy link

Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if bcprov-jdk15on is required, it will be a stand-alone PR.

@halibobo1205 halibobo1205 merged commit be07f5c into tronprotocol:develop

Nov 24, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jwrct jwrct Awaiting requested review from jwrct

@forfreeday forfreeday Awaiting requested review from forfreeday

2 more reviewers

@317787106 317787106 317787106 left review comments

@tomatoishealthy tomatoishealthy tomatoishealthy approved these changes

Reviewers whose approvals may not affect merge requirements

Labels

None yet

Projects

None yet

Milestone

GreatVoyage-v4.7.4

Development

Successfully merging this pull request may close these issues.

3 participants

@halibobo1205 @317787106 @tomatoishealthy