feat(net): add column codeVersion to HelloMessage by 317787106 · Pull Request #5584

feat(net): add column codeVersion to HelloMessage by 317787106 · Pull Request #5584 · tronprotocol/java-tron

Conversation

What does this PR do?

add column codeVersion to HelloMessage

Why are these changes required?

know more information about peer

This PR has been tested by:

Unit Tests
Manual Testing

Follow up

Extra details

jiangyuanshu added 2 commits

November 15, 2023 16:08


		ByteString signature = helloMessage.getSignature();
		if (signature != null && !signature.isEmpty()) {
		if (!signature.isEmpty()) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this field has some relationship with the codeVersion?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this field has some relationship with the codeVersion?

No, only code optimization.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

933756

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ma ja sam na neki način i u teretani i ja Pa Pa

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Zakačite stavke ostave kako ne bi istekle nakon 1 časa

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prevucite stavke iz međuspremnika da biste ih izbrisali

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🇦🇸🇦🇩🇦🇩Fg0x1cfa5e643a3436d94732f65561f8c86e2ea910beZakačite stavke ostave kako ne bi istekle nakon 1 časa

		.append(signature.toByteArray().length).append("\n");
		}

		ByteString codeVersion = helloMessage.getCodeVersion();

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this codeVersion be null when received a HelloMessage from a node with previous version ?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Every column in proto has default value. codeVersion has default value byte[0], not null.

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 66.37%. Comparing base (df52667) to head (54704c2).
Report is 228 commits behind head on develop.

Files with missing lines	Patch %	Lines
.../tron/core/net/message/handshake/HelloMessage.java	71.42%	0 Missing and 2 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@              Coverage Diff              @@
##             develop    #5584      +/-   ##
=============================================
- Coverage      66.43%   66.37%   -0.07%     
+ Complexity     10216    10206      -10     
=============================================
  Files            894      894              
  Lines          53841    53846       +5     
  Branches        5931     5932       +1     
=============================================
- Hits           35768    35738      -30     
- Misses         15284    15315      +31     
- Partials        2789     2793       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix and push through Tron Project

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

		HelloMessage helloMessage = new HelloMessage(node, System.currentTimeMillis(),
		ChainBaseManager.getChainBaseManager());

		Assert.assertEquals(Version.getVersion(),

Conversation

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Reviewers