Home Original page

feat(net): delete config item node.discovery.bind.ip by 317787106 · Pull Request #5597 · tronprotocol/java-tron

Conversation

@317787106

What does this PR do?

  • delete config item node.discovery.bind.ip
  • update libp2p version, include snappy-java version

Why are these changes required?

This PR has been tested by:

  • Unit Tests
  • Manual Testing

Follow up

Extra details

jwrct

PARAMETER.nodeDiscoveryBindIp = s.getLocalAddress().getHostAddress();
} catch (IOException e) {
logger.warn("Can't get bind IP. Fall back to 127.0.0.1: " + e);
PARAMETER.nodeDiscoveryBindIp = "127.0.0.1";

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why should this logic be retained?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if the external ip is not exist, use LAN IP.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why hardcoded into www.baidu.com?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@halibobo1205 It has been moved to libp2p module. This url is not necessary and we can use alternative way.

xxo1shine

jiangyuanshu added 2 commits

December 27, 2023 15:14

jwrct