fix(testcase): remove peer from PeerManager after testcase by 317787106 · Pull Request #6486

fix(testcase): remove peer from PeerManager after testcase by 317787106 · Pull Request #6486 · tronprotocol/java-tron

Conversation

What does this PR do?

remove peer from PeerManager after testcase, fix RpcApiServicesTest.testGetNodeInfo
add log when receives keep alive message in BackupManager to help for debug
check if tronNetDelegate is null in PeerStatusCheck to fix NullPointerException when use mock in several testcases, such as org.tron.core.net.peer.PeerStatusCheckMockTest. NullPointerException occurs only in mock test.

Why are these changes required?

This PR has been tested by:

Follow up

Extra details

		public void clearPeers() {
		for (PeerConnection p : PeerManager.getPeers()) {
		PeerManager.remove(p.getChannel());
		}

The reason will be displayed to describe this comment to others. Learn more.

add Args.clearParam(); ?

The reason will be displayed to describe this comment to others. Learn more.

This testcase has extended BaseTest which implements Args.clearParam() in @afterclass method.

		return;
		}

		logger.info("Receive keep alive message from {}", sender);

The reason will be displayed to describe this comment to others. Learn more.

Maybe it should be sender.getHostString() to keep consistency with lines 121 and 126？

The reason will be displayed to describe this comment to others. Learn more.

Actually, it's more accurate to logging InetSocketAddress, the style is /IP:port. Line 126 only needs IP

warku123 pushed a commit to warku123/java-tron that referenced this pull request

…col#6486)

* remove peer from PeerManager after testcase
* add coverage of NodeInfoServiceTest