Feature: Support using trpc protocol at remote side by weimch · Pull Request #124 · trpc-group/trpc-cpp

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@weimch

Copy link Copy Markdown

Contributor

@weimch weimch commented

Mar 21, 2024

  • import remote side trpc.proto at "trpc/trpc.proto" file.
  • use remote side trpc_options.proto instead local one.
  • intergate remote trpc protocol repo with bazel and cmake compiling progress.
- import remote side trpc.proto at "trpc/trpc.proto" file.
- use remote side trpc_options.proto instead local one.
- intergate remote trpc protocol repo with bazel and cmake compiling progress.

@codecov

Copy link Copy Markdown

codecov bot commented

Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.64704%. Comparing base (53be380) to head (ef6f752).

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##                main        #124         +/-   ##
===================================================
- Coverage   81.66180%   81.64704%   -0.01476%     
===================================================
  Files            855         855                 
  Lines          33891       33891                 
===================================================
- Hits           27676       27671          -5     
- Misses          6215        6220          +5     

see 5 files with indirect coverage changes

Copy link Copy Markdown

Contributor

@helloopenworld helloopenworld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approve

@helloopenworld helloopenworld merged commit 00af5f2 into trpc-group:main

Mar 21, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@helloopenworld helloopenworld helloopenworld approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@weimch @helloopenworld