Feature: During graceful shutdown, more precise control over the readability and writability events of connections to reduce timeouts by yujun411522 · Pull Request #125 · trpc-group/trpc-cpp
Navigation Menu
{{ message }}
trpc-group / trpc-cpp Public
- Notifications You must be signed in to change notification settings
- Fork 107
Merged
helloopenworld merged 1 commit intotrpc-group:mainfrom
Apr 1, 2024Conversation
Copy link Copy Markdown
Contributor
yujun411522
commented
Mar 29, 2024
yujun411522
commented
During graceful shutdown, more precise control over the readability and writability events of connections to reduce timeouts
yujun411522
closed this
yujun411522
reopened this
Copy link Copy Markdown
Codecov Report
Attention: Patch coverage is 87.50000% with 1 lines in your changes are missing coverage. Please review.
Project coverage is 81.60713%. Comparing base (
00af5f2) to head (36d14b4).
Additional details and impacted files
@@ Coverage Diff @@ ## main #125 +/- ## =================================================== - Coverage 81.73851% 81.60713% -0.13139% =================================================== Files 855 855 Lines 33891 33899 +8 =================================================== - Hits 27702 27664 -38 - Misses 6189 6235 +46
| Files | Coverage Δ | |
|---|---|---|
| trpc/server/trpc_server.cc | 73.21429% <87.50000%> (+0.52909%) |
⬆️ |
…ability and writability events of connections to reduce timeouts
yujun411522
force-pushed
the
feature/disable_event_when_stop
branch
from
1863ae6 to
36d14b4
Compare
helloopenworld approved these changes Apr 1, 2024
|
|
||
| // Disable the readable event for the listening socket to avoid creating new connections | ||
| // Disable the readable event for the connected socket to avoid receiving new requests | ||
| std::vector<ServiceAdapterPtr> stop_listened_adapters; |
Copy link Copy Markdown
Contributor
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update doc？
helloopenworld
merged commit
b63513b
into
trpc-group:main
yujun411522
deleted the
feature/disable_event_when_stop
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants