Migrate to a new V8 interceptors Api by isheludko · Pull Request #180 · v8/node

@isheludko

The new callback should return v8::Intercepted::kYes/kNo to indicate
whether the operation was intercepted. This replaces the old approach
where the callback had to leave the return value unset or set it to
an empty handle to indicate that the the request wasn't intercepted.

See https://crrev.com/c/5465509 and https://crrev.com/c/5465513.

@isheludko mentioned this pull request

Apr 22, 2024

victorgomes added a commit that referenced this pull request

Apr 23, 2024
The new callback should return v8::Intercepted::kYes/kNo to indicate
whether the operation was intercepted. This replaces the old approach
where the callback had to leave the return value unset or set it to
an empty handle to indicate that the the request wasn't intercepted.

See https://crrev.com/c/5465509 and https://crrev.com/c/5465513.
# Conflicts:
#	src/node_contextify.cc

targos pushed a commit to targos/node that referenced this pull request

Apr 29, 2024

nodejs-github-bot pushed a commit to nodejs/node that referenced this pull request

May 1, 2024
Refs: v8#180
PR-URL: #52745
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>

Ch3nYuY pushed a commit to Ch3nYuY/node that referenced this pull request

May 8, 2024
Refs: v8#180
PR-URL: nodejs#52745
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>

targos added a commit to nodejs/node that referenced this pull request

May 8, 2024
Refs: v8#180
PR-URL: #52745
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>

victorgomes added a commit that referenced this pull request

Jun 3, 2024
The new callback should return v8::Intercepted::kYes/kNo to indicate
whether the operation was intercepted. This replaces the old approach
where the callback had to leave the return value unset or set it to
an empty handle to indicate that the the request wasn't intercepted.

See https://crrev.com/c/5465509 and https://crrev.com/c/5465513.
# Conflicts:
#	src/node_contextify.cc

# Conflicts:
#	src/node_contextify.cc
#	src/node_env_var.cc

sophoniie pushed a commit to sophoniie/node that referenced this pull request

Jun 20, 2024
Refs: v8#180
PR-URL: nodejs#52745
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>

bmeck pushed a commit to bmeck/node that referenced this pull request

Jun 22, 2024
Refs: v8#180
PR-URL: nodejs#52745
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>

pthier pushed a commit that referenced this pull request

Jul 15, 2024
The new callback should return v8::Intercepted::kYes/kNo to indicate
whether the operation was intercepted. This replaces the old approach
where the callback had to leave the return value unset or set it to
an empty handle to indicate that the the request wasn't intercepted.

See https://crrev.com/c/5465509 and https://crrev.com/c/5465513.
# Conflicts:
#	src/node_contextify.cc

# Conflicts:
#	src/node_contextify.cc
#	src/node_env_var.cc

victorgomes added a commit that referenced this pull request

Aug 22, 2024
The new callback should return v8::Intercepted::kYes/kNo to indicate
whether the operation was intercepted. This replaces the old approach
where the callback had to leave the return value unset or set it to
an empty handle to indicate that the the request wasn't intercepted.

See https://crrev.com/c/5465509 and https://crrev.com/c/5465513.
# Conflicts:
#	src/node_contextify.cc

# Conflicts:
#	src/node_contextify.cc
#	src/node_env_var.cc

pthier pushed a commit that referenced this pull request

Oct 2, 2024
The new callback should return v8::Intercepted::kYes/kNo to indicate
whether the operation was intercepted. This replaces the old approach
where the callback had to leave the return value unset or set it to
an empty handle to indicate that the the request wasn't intercepted.

See https://crrev.com/c/5465509 and https://crrev.com/c/5465513.
# Conflicts:
#	src/node_contextify.cc

# Conflicts:
#	src/node_contextify.cc
#	src/node_env_var.cc

victorgomes added a commit that referenced this pull request

Nov 18, 2024
The new callback should return v8::Intercepted::kYes/kNo to indicate
whether the operation was intercepted. This replaces the old approach
where the callback had to leave the return value unset or set it to
an empty handle to indicate that the the request wasn't intercepted.

See https://crrev.com/c/5465509 and https://crrev.com/c/5465513.
# Conflicts:
#	src/node_contextify.cc

# Conflicts:
#	src/node_contextify.cc
#	src/node_env_var.cc

victorgomes added a commit that referenced this pull request

Dec 18, 2024
The new callback should return v8::Intercepted::kYes/kNo to indicate
whether the operation was intercepted. This replaces the old approach
where the callback had to leave the return value unset or set it to
an empty handle to indicate that the the request wasn't intercepted.

See https://crrev.com/c/5465509 and https://crrev.com/c/5465513.
# Conflicts:
#	src/node_contextify.cc

# Conflicts:
#	src/node_contextify.cc
#	src/node_env_var.cc

# Conflicts:
#	src/node_env_var.cc