Home Original page

feat(isEAN) - added support for EAN-14 along with test case, feat(isAlphanumeric)- added options(optional parameter) by varsubham · Pull Request #1577 · validatorjs/validator.js

@varsubham

@varsubham

@codecov

@varsubham varsubham changed the title added support for EAN-14 along with test case feat(isEAN) - added support for EAN-14 along with test case, feat(isAlphanumeric)- added options(optional parameter)

Jan 18, 2021

@varsubham

@varsubham

@profnandaa Hey can you please review the PR its one of my first PR 😄.
If there are any errors please let me know. 🙂

@renanmontebelo

I believe they are waiting for #1553 before reviewing any other PR.

@renanmontebelo

I believe the PR should only include files under src/, test/ and README.md; /validator.js and /validator.min.js are automatically generated by the build process (and by npm test) if I'm not mistaken.

@varsubham

@renanmontebelo I thought that we need to check if all the test cases are running (npm test) before submitting a PR 🤔

@renanmontebelo

These files are listed in .gitignore so I believe they shouldn't be added. Still, someone accidently added them that's why it's yielding as a modified file. See #1590 discussion.

@tux-tn

@tux-tn

tux-tn

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you and congrats for your first contrib @varsubham . I deleted validator.js and validator.min.js to fix merge conflicts, apart from that LGTM 🎉

profnandaa

This was referenced

Mar 8, 2021