Home Original page

fix(isSlug & rtrim): regex no longer exposed to ReDOS attacks by fedeci · Pull Request #1603 · validatorjs/validator.js

Conversation

@fedeci

This should be merged after #1602
Regexes are updated in order not to change their behaviour, but only their logic.

Fixes #1596 and fixes #1599

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

@codecov

tux-tn

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉 thank you for spotting and fixing the ReDOS

profnandaa

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@HHogg HHogg mentioned this pull request

Oct 20, 2021

This was referenced

Oct 28, 2021

This was referenced

Nov 11, 2021

Labels