Home Original page

bugfix(isMobilePhone.js): Updating regex of Belgium and the valid and invalid phone numbers in validators.js by divikshrivastava · Pull Request #1746 · validatorjs/validator.js

Conversation

@divikshrivastava

This PR contains the updation of regex for Belgian's mobile number validation (nl-BE), along with correction of valid and invalid numbers in validators.js

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

Divik Shrivastava added 2 commits

October 2, 2021 19:14

tux-tn

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @divikshrivastava and congrats for your first PR here 👏
Your tests are not passing, can you please fix that?

@divikshrivastava

Thank you @divikshrivastava and congrats for your first PR here 👏 Your tests are not passing, can you please fix that?

…js since phone number rules will be same for that too

@codecov

tux-tn

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉
Is your participation as part of hacktoberfest ?

@divikshrivastava

profnandaa

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! 🎉

Labels