check more special characters when validating a FQDN by MatteoPierro ยท Pull Request #1799 ยท validatorjs/validator.js

@MatteoPierro

@MatteoPierro

@codecov

@MatteoPierro

This should also close the issue #1087

@MatteoPierro

Ei @tux-tn Can I have your feedback about this? ๐Ÿ˜‡

@tux-tn

@MatteoPierro Yes sir! i'm reviewing some pending PRs, i will probably check yours today! Thank you

tux-tn

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MatteoPierro

May I ask if you can add the label hacktoberfest-accepted ? ๐Ÿ‘€

@tux-tn

May I ask if you can add the label hacktoberfest-accepted ? ๐Ÿ‘€

Done ๐Ÿ˜ƒ

profnandaa

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! ๐ŸŽ‰

theteladras pushed a commit to theteladras/validator.js that referenced this pull request

Oct 30, 2021

profnandaa pushed a commit that referenced this pull request

Oct 31, 2021

profnandaa pushed a commit that referenced this pull request

Oct 31, 2021

@deltoro05