fix(matches): prevent regex state from breaking following validations by fedeci · Pull Request #1975

fix(matches): prevent regex state from breaking following validations by fedeci · Pull Request #1975 · validatorjs/validator.js

Conversation

		pattern = new RegExp(pattern, modifiers);
		}
		return pattern.test(str);
		return !!str.match(pattern);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.test keeps the state when used along with a regex that has the global or the sticky flag. We can prevent that behaviour getting stateless validation using .match

/cc @tux-tn @ezkemboi

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about using Array.isArray(str.match(pattern)) or str.match(pattern) !== null since the possible return values of .matches are Array or null?
The result is obviously the same, but semantically seems more appropriate to me :)
And maybe they'll be more inclined to accept the PR :)