feat(isMobilePhone): Added regex for Aruba nl-AW by adida948 · Pull Request #1985 · validatorjs/validator.js
Added validation for Aruba on isMobilePhone.
referred issue: #1761
Checklist
- PR contains only changes related; no stray files, etc.
- README updated (where applicable)
- Tests written (where applicable)
rubiin previously approved these changes Jun 21, 2022
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tux-tn previously approved these changes Jun 24, 2022
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
Thank you for your PR @adida948
@rubiin -- you'd an invite to join the org, let me resend. Thanks for your review on this too!
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just the m/c which I'll fix on a bulk PR before release.
HI, let me know if there is anything else needed from my side.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On Readme there is still the merge markers. please remove that
@rubiin tried the github UI. I messed up the update. Did it from command line now.
thanks. I have removed them
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters