feat(isIBAN): add Morocco (MA) IBAN format by lroudge · Pull Request #2025 · validatorjs/validator.js

Conversation

@lroudge

Added a regex for Morocco IBAN format in isIBAN validator

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

@codecov

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (4ff897b) compared to base (6dba289).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #2025   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          105       105           
  Lines         2334      2334           
  Branches       586       586           
=========================================
  Hits          2334      2334           
Impacted Files Coverage Δ
src/lib/isIBAN.js 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lroudge lroudge marked this pull request as ready for review

August 12, 2022 13:57

@lroudge

HI @WikiRik, if you have a chance to look at this I would be very grateful, thanks!

WikiRik

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lroudge

Hello @chriso, I thought @WikiRik review would be enough to merge this PR but I didn't realize they were not in the list of maintainers. Do you mind taking a look please? Thanks a lot!

pano9000

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, from what I could gather online

profnandaa

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contrib! 🎉

@vky5 vky5 mentioned this pull request

Jul 30, 2024

This was referenced

Aug 30, 2024

This was referenced

Sep 10, 2024

@vky5 vky5 mentioned this pull request

Sep 15, 2024

This was referenced

Sep 19, 2024

Labels