feat(isIP): allow usage of options object by pixelbucket-dev · Pull Request #2089

feat(isIP): allow usage of options object by pixelbucket-dev · Pull Request #2089 · validatorjs/validator.js

Conversation

This PR implements steps 1 and 2 of #1874 for isIP and builds upon #2075.

This PR extracts tests for isIP into a separate test file ⇾ test/validators/isIP.test.js (inspired by #1793).

I have also added three more tests to guard against other possible values for version.

Checklist

PR contains only changes related; no stray files, etc.
README updated (where applicable)
Tests written (where applicable)

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (54d330c) to head (0cace52).
Report is 98 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff            @@
##            master     #2089   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          105       105           
  Lines         2324      2324           
  Branches       586       587    +1     
=========================================
  Hits          2324      2324

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

if we rebase/merge this with #2091, the diff will be much cleaner and easier to review

if we rebase/merge this with #2091, the diff will be much cleaner and easier to review

I've merged #2091 into this branch. But the diff won't be improved until #2091 is merged.

if we rebase/merge this with #2091, the diff will be much cleaner and easier to review

I've merged #2091 into this branch. But the diff won't be improved until #2091 is merged.

Ah, of course. And I suppose it's possible to set 2091 as the base branch, either.

Ah, of course. And I suppose it's possible to set 2091 as the base branch, either.

It is possible, but then it would be a PR in my fork and not this repo directly. So we'll have to deal with this workaround for now

I think this should be good to go :).

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you undo the changes to the isAlpha tests?

Can you undo the changes to the isAlpha tests?

Sorry, what exactly do you mean? I cannot see anything related to isAlpha in the diff view.

In the big test file you removed too much for this PR causing the codecov check to fail

In the big test file you removed too much for this PR causing the codecov check to fail

Done :).