refactor: change test files to prepare for #1874 by WikiRik · Pull Request #2091 · validatorjs/validator.js
This PR takes away some of the changes in #2075 and related PRs built on that which are needed to implement #1874. This way the PRs that build on this do not have unrelated changes to isAfter.
Checklist
- PR contains only changes related; no stray files, etc.
- README updated (where applicable)
- Tests written (where applicable)
Codecov Report
Base: 100.00% // Head: 100.00% // No change to project coverage 👍
Coverage data is based on head (
e01385a) compared to base (7bef722).
Patch has no changes to coverable lines.
Additional details and impacted files
@@ Coverage Diff @@ ## master #2091 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 105 105 Lines 2335 2335 Branches 586 586 ========================================= Hits 2335 2335
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.
@pixelbucket-dev could you rebase on this? I've already updated the refactor of isAfter on this
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice!
Would be really nice if we could merge this! That makes it a lot easier to review PRs like #2089
rubiin
added
the
mc-to-land
label
Jan 21, 2023@rubiin Fixed, thanks for the heads up! I'll review the PRs that allow usage of the options object after this has been merged and those PRs have been rebased
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters