Home Original page

fix(isEmail): fixed `isFQDN` still checking email length when `ignore_max_length` is `true` by sakhmedbayev · Pull Request #2128 · validatorjs/validator.js

@sakhmedbayev

Fixed the issue when the ignore_max_length option was not honored (did not have any effect) since the isFQDN function had its own check for the email parts length.

Checklist

  • PR contains only changes related; no stray files, etc.
  • Tests written (where applicable)

@saidakhaccenture

@sakhmedbayev sakhmedbayev changed the title fix(isEmail): fixed isFQDN still checking email length when ignore_max_length is false fix(isEmail): fixed isFQDN still checking email length when ignore_max_length is true

Dec 14, 2022

WikiRik

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good, don't forget to document the new option for isFQDN in the README

@saidakhaccenture

@sakhmedbayev

Code changes look good, don't forget to document the new option for isFQDN in the README

@WikiRik, thanks, documented

WikiRik

rubiin

profnandaa

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix! 🎉

profnandaa added a commit that referenced this pull request

Feb 1, 2023 
…_max_length` is `true` (#2170)

profnandaa: clean-up #2128

---------

Co-authored-by: Said Akhmedbayev <said.akhmedbayev@accenture.com>

@profnandaa

profnandaa added a commit that referenced this pull request

Feb 1, 2023 
fix(isEmail): fixed `isFQDN` still checking email length when
 `ignore_max_length` is `true`

profnandaa: clean-up #2128

---------

Co-authored-by: Said Akhmedbayev <said.akh@gmail.com>
Co-authored-by: Said Akhmedbayev <said.akhmedbayev@accenture.com>