fix(isPostalCode): Fix overly permissive BY regexp by pano9000 · Pull Request #2134

fix(isPostalCode): Fix overly permissive BY regexp by pano9000 · Pull Request #2134 · validatorjs/validator.js

add missing start of line anchor ^
remove meaningless {1} quantifier

Checklist

PR contains only changes related; no stray files, etc.
~~[ ] README updated (where applicable)~~
~~[ ] Tests written (where applicable)~~

* add missing start of line anchor
* remove meaningless `{1}` quantifier

Fixes validatorjs#2133

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (843584e) compared to base (531dc7f).
Patch has no changes to coverable lines.

Additional details and impacted files

@@            Coverage Diff            @@
##            master     #2134   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          104       104           
  Lines         2308      2308           
  Branches       578       578           
=========================================
  Hits          2308      2308

Impacted Files	Coverage Δ
src/lib/isPostalCode.js	`100.00% <ø> (ø)`

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Maybe add a test for postal codes that are now marked as invalid?

had to add a full block of "invalid" tests, because for some reason, there were none to begin with :-(
(which is why I also originally did not include those invalid tests in my PR)

Checklist

Codecov Report

Choose a reason for hiding this comment