feat(isMobilePhone): Add regex for Somalia so-SO by ohersi · Pull Request #2175 · validatorjs/validator.js

Conversation

profnandaa

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, we're just about to make our next release and the preps are done. Unfortunately this will miss the train but should be on the next one.

Please fix the merge conflicts.

ezkemboi

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ezkemboi

ezkemboi

ezkemboi

@codecov

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (f89e0a8) compared to base (54d330c).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #2175   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          105       105           
  Lines         2324      2324           
  Branches       586       586           
=========================================
  Hits          2324      2324           
Impacted Files Coverage Δ
src/lib/isMobilePhone.js 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

rubiin

profnandaa

This was referenced

Jul 19, 2024

@vky5 vky5 mentioned this pull request

Jul 30, 2024

This was referenced

Aug 30, 2024

This was referenced

Sep 10, 2024

@vky5 vky5 mentioned this pull request

Sep 15, 2024

Labels