Modified symbolRegex in isStrongPassword to include '\' by nandavikas · Pull Request #2278 · validatorjs/validator.js

Conversation

@nandavikas

isStrongPassword - Bug fix

I modified the special character regex a little bit to add validation for '\' character. I worked on this based on an issue in the repository

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)
  • References provided in PR (where applicable)

@codecov

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (b958bd7) 99.95% compared to head (8c06778) 99.95%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2278   +/-   ##
=======================================
  Coverage   99.95%   99.95%           
=======================================
  Files         107      107           
  Lines        2454     2454           
  Branches      619      619           
=======================================
  Hits         2453     2453           
  Partials        1        1           
Files Changed Coverage Δ
src/lib/isStrongPassword.js 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@WikiRik

Thanks for the PR! Don't forget to add additional tests before we can review this

WikiRik

manojmula

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are working and changes are legit.

profnandaa

@vky5 vky5 mentioned this pull request

May 31, 2024

@vky5 vky5 mentioned this pull request

Sep 15, 2024

This was referenced

Sep 20, 2024

This was referenced

Sep 22, 2024